Skip to content

Deno 2.3.2 adds RegExp.escape #26936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 30, 2025
Merged

Deno 2.3.2 adds RegExp.escape #26936

merged 3 commits into from
May 30, 2025

Conversation

finxol
Copy link
Contributor

@finxol finxol commented May 29, 2025

Summary

Add new Deno version

Update support for RegExp.escape() in Deno.

Test results and supporting details

Deno v2.3 released.

RegExp.escape() is supported in Deno since v2.3.2.

See v2.3.3 release notes.

Related issues

RegExp.escape() is supported in Deno since [v2.3.2](denoland/deno#29186).

See [v2.3.3 release notes](https://github.com/denoland/deno/releases/tag/v2.3.3).
@github-actions github-actions bot added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:xs [PR only] 0-6 LoC changed labels May 29, 2025
Copy link
Contributor

github-actions bot commented May 29, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@finxol finxol marked this pull request as draft May 29, 2025 15:16
@github-actions github-actions bot added data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. size:s [PR only] 7-24 LoC changed labels May 29, 2025
@finxol finxol changed the title Add RegExp.escape for Deno Add Deno verison + RegExp.escape May 29, 2025
@finxol finxol marked this pull request as ready for review May 29, 2025 15:23
@@ -212,7 +212,7 @@
},
"chrome_android": "mirror",
"deno": {
"version_added": false
"version_added": "2.3"
Copy link

@zloirock zloirock May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Снимок экрана 2025-05-29 в 18 51 21 Снимок экрана 2025-05-29 в 18 46 51

?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mentioned PR includes only .d.ts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Снимок экрана 2025-05-29 в 18 51 21 Снимок экрана 2025-05-29 в 18 46 51

?

I can't find any mention of a 2.4 release anywhere. Can you find a blog post or some release notes somewhere?

The mentioned PR includes only .d.ts.

Yes, but from testing, RegExp.escape() works in Deno v2.3.3.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I received this version from deno upgrade a couple of weeks ago. That's strange.

Yes, I have downloaded 2.3.3 and it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-05-29 at 18 08 11

The example from MDN docs works with v2.3.3

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After installing 2.3.3, it shows 2.3.3 as the latest. Maybe false start on the releasing process...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": "2.3"
"version_added": "2.3.2"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caugner both should be added: 2.3.0 - 13.4 -> 13.5, 2.3.2 - 13.5 -> 13.7.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zloirock Absolutely, see also #26936 (review).

Copy link

@zloirock zloirock May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caugner it was the answer to your suggested change - sorry, I thought that it was a change in browsers/deno.

@zloirock
Copy link

Current Deno mapping contains only minor versions, but here V8 was bumped 13.5 -> 13.7 in Deno 2.3.2, so maybe makes sense to add it too?

@finxol
Copy link
Contributor Author

finxol commented May 29, 2025

Current Deno mapping contains only minor versions, but here V8 was bumped 13.5 -> 13.7 in Deno 2.3.2, so maybe makes sense to add it too?

Do you mean add 2.3.2 to browsers/deno.json too ?
I didn't do it because it'd be inconsistent with all other entries in the file.

@zloirock
Copy link

@finxol it's a question for BCD maintainers.

Previously, I remember only a couple of such updates - one was reverted, another was recognized as a mistake. Now, apparently, the situation is different.

@caugner caugner changed the title Add Deno verison + RegExp.escape Deno 2.3.2 adds RegExp.escape May 30, 2025
@caugner
Copy link
Contributor

caugner commented May 30, 2025

Thanks @finxol @zloirock.

Given that Deno 2.3.2 upgraded V8, let's indeed track this patch version separately.

Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set version_added: "2.3.2", and add the Deno 2.3.2 release, but also keep the Deno 2.3 release.

@@ -212,7 +212,7 @@
},
"chrome_android": "mirror",
"deno": {
"version_added": false
"version_added": "2.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": "2.3"
"version_added": "2.3.2"

@finxol
Copy link
Contributor Author

finxol commented May 30, 2025

I've added v2.3.2, but release notes links to v2.3.3, the release details have been moved because of a regression in v2.3.2

@finxol finxol requested a review from caugner May 30, 2025 15:08
@caugner caugner merged commit 810ab02 into mdn:main May 30, 2025
6 checks passed
@mdn-bot mdn-bot mentioned this pull request May 30, 2025
@finxol finxol deleted the patch-1 branch May 30, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:s [PR only] 7-24 LoC changed size:xs [PR only] 0-6 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants