-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Deno 2.3.2 adds RegExp.escape
#26936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RegExp.escape() is supported in Deno since [v2.3.2](denoland/deno#29186). See [v2.3.3 release notes](https://github.com/denoland/deno/releases/tag/v2.3.3).
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
javascript/builtins/RegExp.json
Outdated
@@ -212,7 +212,7 @@ | |||
}, | |||
"chrome_android": "mirror", | |||
"deno": { | |||
"version_added": false | |||
"version_added": "2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mentioned PR includes only .d.ts
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I received this version from deno upgrade
a couple of weeks ago. That's strange.
Yes, I have downloaded 2.3.3 and it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

The example from MDN docs works with v2.3.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After installing 2.3.3, it shows 2.3.3 as the latest. Maybe false start on the releasing process...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version_added": "2.3" | |
"version_added": "2.3.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caugner both should be added: 2.3.0
- 13.4
-> 13.5
, 2.3.2
- 13.5
-> 13.7
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zloirock Absolutely, see also #26936 (review).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@caugner it was the answer to your suggested change - sorry, I thought that it was a change in browsers/deno
.
Current Deno mapping contains only minor versions, but here V8 was bumped 13.5 -> 13.7 in Deno 2.3.2, so maybe makes sense to add it too? |
Do you mean add 2.3.2 to |
@finxol it's a question for BCD maintainers. Previously, I remember only a couple of such updates - one was reverted, another was recognized as a mistake. Now, apparently, the situation is different. |
RegExp.escape
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's set version_added: "2.3.2"
, and add the Deno 2.3.2 release, but also keep the Deno 2.3 release.
javascript/builtins/RegExp.json
Outdated
@@ -212,7 +212,7 @@ | |||
}, | |||
"chrome_android": "mirror", | |||
"deno": { | |||
"version_added": false | |||
"version_added": "2.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"version_added": "2.3" | |
"version_added": "2.3.2" |
I've added v2.3.2, but release notes links to v2.3.3, the release details have been moved because of a regression in v2.3.2 |
Summary
Add new Deno version
Update support for
RegExp.escape()
in Deno.Test results and supporting details
Deno v2.3 released.
RegExp.escape() is supported in Deno since v2.3.2.
See v2.3.3 release notes.
Related issues